Evaluation system and cli compatibility with query reformulation#235
Merged
NicolasLMP merged 8 commits intomainfrom Jul 31, 2025
Merged
Evaluation system and cli compatibility with query reformulation#235NicolasLMP merged 8 commits intomainfrom
NicolasLMP merged 8 commits intomainfrom
Conversation
NicolasLMP
changed the title
NicolasLMP
commented
Jul 31, 2025
Collaborator
Author
NicolasLMP
left a comment
NicolasLMP
left a comment
There was a problem hiding this comment.
We keep the print for the moment
src/webapp/app.py
Outdated
| "Analyse de votre question...", | ||
| "Recherche d'informations pertinentes...", | ||
| "Consultation de la base de connaissances...", | ||
| "Formulation d'une réponse...", |
| from src.storage.data_manager import get_data_manager | ||
| # Quick check: if this is the first question in session, skip database query | ||
| if len(st.session_state.get("messages", [])) <= 1: | ||
| print("📚 HISTORY: First question - skipping database query") |
Collaborator
Author
There was a problem hiding this comment.
Maybe use a log instead of a print
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does :