MOB-11663-InApp-Calculations #949
Open
+215
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs reduction in code. Lot of repition. Heavy review and testing needed. Committing as inapps are looking stable and are sticking with the layout with back to back phone rotations when inapp performance would fail usually
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| private String messageId; | ||
|
|
||
| // Resize debouncing fields | ||
| private Handler resizeHandler = new Handler(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| lastOrientation = currentOrientation; | ||
|
|
||
| // Use longer delay for orientation changes to allow layout to stabilize | ||
| final Handler handler = new Handler(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
Ayyanchira
force-pushed
the
MOB-11663-InApp-Calculations
branch
from
2cc8a75 to
8e15c0a
Compare
Ayyanchira
commented
Oct 30, 2025
iterableapi/src/androidTest/java/com/iterable/iterableapi/IterableApiResponseTest.java
Show resolved
Hide resolved
Ayyanchira
commented
Oct 30, 2025
Comment on lines
+212
to
+215
| if (loaded && webView != null) { | ||
| // Only trigger on significant orientation changes (90 degree increments) | ||
| int currentOrientation = ((orientation + 45) / 90) * 90; | ||
| if (currentOrientation != lastOrientation && lastOrientation != -1) { | ||
| lastOrientation = currentOrientation; | ||
|
|
||
| // Use longer delay for orientation changes to allow layout to stabilize |
There was a problem hiding this comment.
This allows for resize script to be called only limted number of times. This method when implemented, felt it was only called when landscape to portrait rotation was made. Hence explicit conditioning is required.
iterableapi/src/main/java/com/iterable/iterableapi/IterableInAppFragmentHTMLNotification.java
Outdated
Show resolved
Hide resolved
iterableapi/src/main/java/com/iterable/iterableapi/IterableInAppFragmentHTMLNotification.java
Show resolved
Hide resolved
And removed unnecessary logging
Ayyanchira
force-pushed
the
MOB-11663-InApp-Calculations
branch
from
54b0276 to
e85d78a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs reduction in code. Lot of repition. Heavy review and testing needed. Committing as inapps are looking stable and are sticking with the layout with back to back phone rotations when inapp performance would fail usually
🔹 Jira Ticket(s) if any
✏️ Description