J01 95 be 댓글 생성 로직에 누락된 기능 추가 #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 컴포넌트 댓글 수를 증가/감소 이벤트를 구독하는 리스너 추가
- 댓글 이미지 경로 이동 이벤트를 구독하는 리스너 추가
kmw2378
added
✔︎pull requests
- 이미지가 없는 경우 메서드를 종료하도록 수정
- StorageService 대신 CommentImageEventListener 를 사용하도록 변경
SSUHYUNKIM
approved these changes
Feb 8, 2025
| private final ComponentRepository componentRepository; | ||
|
|
||
| @Async | ||
| @Transactional(propagation = Propagation.REQUIRES_NEW) |
Contributor
There was a problem hiding this comment.
궁금증) Progation.REQUIRES_NEW에 대해서 찾아봤는데 댓글 저장은 롤백되더라도, 댓글 수 증가 이벤트는 정상적으로 반영됨! 이라고 나와서 저장이 롤백되면 댓글 증가 이벤트도 반영이 안되어야하는게 아닌가요?
Contributor
Author
There was a problem hiding this comment.
어우 그 부분을 고려 못했네요.. 감사합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
componentId검증 로직 추가componentId와parentId간 관계 검증 로직 추가ComponentCommentCountIncreaseEvent)ComponentCommentCountEventListener)StorageService사용CommentImageEventListener)ComponentCommentCountDecreaseEvent)ComponentCommentCountEventListener)StorageService사용CommentImageEventListener)Listener로 변경테스트
Repository
Service
Controller
기타 사항 (참고 자료, 문의 사항 등)