-
Notifications
You must be signed in to change notification settings - Fork 3
✨ feat: 다크 모드 구현 #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ccconac
wants to merge
20
commits into
dev
Choose a base branch
from
faet/206-dark-theme
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
✨ feat: 다크 모드 구현 #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 체크리스트
📝 작업 상세 내용
localStorage에boolean타입으로 지정됩니다./hooks/useTheme.ts
/components/Layout/Layout.tsx
Layout컴포넌트의 요소들을styled-components의ThemeProvider로 감싸 줬습니다.theme를 관리해야 하는 설정 페이지 제외)isDarkMode값이true일 경우semantic상수의dark객체 하위 색상으로 변경됩니다.🚨 버그 발생 이유 (선택 사항)
🔎 후속 작업 (선택 사항)
url을 컴포넌트의props로 전달해 사용하고 있는 것을 확인했습니다.🤔 질문 사항 (선택 사항)
📚 참고 자료 (선택 사항)
📸 스크린샷 (선택 사항)
✅ 셀프 체크리스트
이슈 번호: #206