refactor: 여행 회고 응답 DTO에 StudyLogId 목록 추가(#101) #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: StudyLogQueryRepository, StudyLogQueryRepositoryAdapter에 findAllIdsByTripIdOrderByCreatedDesc 메서드 추가 * feat: StudyLogQueryService에 getStudyLogIdsByTripId 메서드 추가 * refactor: TripRetrospectSummary에 List<Long> studyLogIds 추가 * refactor: LoadTripRetrospectDetailResponse에 List<Long> studyLogIds 추가 * test: StudyLogQueryServiceTest에 GetStudyLogIdsByTripId 단위 테스트 추가 * test: TripReportControllerIntegrationTest에서 LoadTripRetrospect 통합 테스트 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 작업 내용 및 특이사항
✅ 여행 회고 응답 DTO 수정
List<Long> studyLogIds를 추가여행 리포트 생성 API에서 요청 값 생성할 때, 기존 방식은 무한 스크롤을 이용해StudyLogId 목록을 전달하는 방식 사용List<Long> studyLogIds를 같이 전달하여, 해당 문제를 해결하고 UX를 향상시킴✅ StudyLogId 목록 조회 메서드 추가
StudyLogQueryRepository,StudyLogQueryRepositoryAdapter에findAllIdsByTripIdOrderByCreatedDesc메서드 추가StudyLogQueryService에getStudyLogIdsByTripId메서드 추가✅ DTO 수정
TripRetrospectSummary에List<Long> studyLogIds추가LoadTripRetrospectDetailResponse에List<Long> studyLogIds추가✅ 테스트
StudyLogQueryServiceTest에GetStudyLogIdsByTripId단위 테스트 추가TripReportControllerIntegrationTest에서LoadTripRetrospect통합 테스트 수정🌱 관련 이슈
🔍 참고사항(선택)
📚 기타(선택)