-
Notifications
You must be signed in to change notification settings - Fork 257
update: script update to account for the Xcode build guard #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5fe378a
update: script update to account for Xcode build guard
zamulla 09d9ec0
update: script update to account for Xcode build guard
zamulla 7654226
fix: SME review
zamulla ae99734
fix: SME review 2.0
zamulla 77ebe67
fix: TW review
zamulla 1e0f2bb
moved image
ElviraMustafina File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -58,15 +58,25 @@ To connect the Kotlin framework generated from the multiplatform project to your | |||||
|
|
||||||
| {width=700} | ||||||
|
|
||||||
| 5. Adjust the following script and paste the result in the run script field: | ||||||
| 5. Adjust the following script and paste it in the script text field of the new phase: | ||||||
|
|
||||||
| ```bash | ||||||
| if [ "YES" = "$OVERRIDE_KOTLIN_BUILD_IDE_SUPPORTED" ]; then | ||||||
| echo "Skipping Gradle build task invocation due to OVERRIDE_KOTLIN_BUILD_IDE_SUPPORTED environment variable set to \"YES\"" | ||||||
| exit 0 | ||||||
| fi | ||||||
| cd "<Path to the root of the multiplatform project>" | ||||||
| ./gradlew :<Shared module name>:embedAndSignAppleFrameworkForXcode | ||||||
| ./gradlew :<Shared module name>:embedAndSignAppleFrameworkForXcode | ||||||
| ``` | ||||||
|
|
||||||
| * In the `cd` command, specify the path to the root of your Kotlin Multiplatform project, for example, `$SRCROOT/..`. | ||||||
| * In the `./gradlew` command, specify the name of the shared module, for example, `:shared` or `:composeApp`. | ||||||
| * When you start an iOS run configuration, IntelliJ IDEA and Android Studio build the Kotlin framework dependency | ||||||
| before starting the Xcode build, and set the `OVERRIDE_KOTLIN_BUILD_IDE_SUPPORTED` environment variable to "YES". | ||||||
| The suggested shell script checks this variable and prevents the Kotlin framework from being built a second time, from Xcode. | ||||||
|
||||||
| The suggested shell script checks this variable and prevents the Kotlin framework from being built a second time, from Xcode. | |
| The provided shell script checks this variable and prevents the Kotlin framework from being built a second time from Xcode. |
ElviraMustafina marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
ElviraMustafina marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very minor but I think the sentence would read better if you replace "IntelliJ IDEA and Android Studio" with "the IDE". So you can eliminate the double "and" (unless it's important to specify both of them).
Also, since it's not an instruction like the previous 2 points, it doesn't need to be a list item.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep the explicit mentions of IntelliJ IDEA and Android Studio since Xcode is also an IDE, and that could be confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to "not a list item." If you want to keep it in the list, you can rewrite it as an action point like "Start your iOS run configuration" and move all the details to a separate paragraph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, IDEs can be ambiguous when we jump around between Xcode and IntelliJ, I keep coming up against this and deciding that it's easier to just mention them both. It's not like there's going to be another IDE on the list any time soon.
As for the list item, agreed, moved this out.