Prevent scroll events during trackpad three finger swipe #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aaronkollasch just wanted to bump this please, would be great to get it in the official build if possible |
|
I should have some time after next week to review. Thanks for your patience! |
@aaronkollasch, It's been almost 5 months. Haven't you had some time to review this pull request yet? |
parameshvee
approved these changes
Jun 28, 2024
|
I would like to see this fixed too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the start of a three finger swipe gesture on trackpad, a small scroll event is generated and not suppressed. This results in the active window scrolling slightly every time a three finger swipe gesture is used.
The variable
magicMouseThreeFingerFlagseems to be preventing this behaviour for Magic Mouse, so introduce a similar flag for trackpad. This fixes the issue.