Skip to content

Conversation

@kvoit
Copy link

@kvoit kvoit commented May 29, 2022

@grostim
Copy link

grostim commented Sep 26, 2022

what prevent this PR to be merged ?

@kvoit
Copy link
Author

kvoit commented Sep 26, 2022

either the fact that this repository clearly isn't maintained anymore, or the fact that this actually breaks compatibility with older IDF versions ... by now, I wouldn't merge it myself in the current state, but haven't brought myself to write a clean version using ESP_IDF_VERSION_MAJOR/ESP_IDF_VERSION_MINOR defines to determine what to include.

@gbetous
Copy link

gbetous commented Jan 3, 2023

Hi there,

Very interested in this project, I wonder if there is a kind of "official fork" still maintained where those MR have been accepted ?

@kvoit
Copy link
Author

kvoit commented Jan 3, 2023

I have just implemented my above mentioned clean solution for both versions in my fork.
https://github.com/kvoit/RemoteDebug.git

I have also taken care of the deprecation warning of esp/sha.h and replaced it with sha/sha_parallel_engine.h. This compiles, but I don't have the hardware here to finally test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants