Skip to content

Conversation

@pdeffebach
Copy link
Collaborator

cc @bkamins

I noticed some issue on my work computer where PrettyTables.jl v3 was accidentally loaded, even though the Project.toml didn't allow for it? I have to explore it more.

However this is a fix to support PrettyTables.jl both 2 and 3, using @static if copying DataFrames.jl.

I think DataFramesMeta.jl has been a little out-of-sync with DataFrames.jl for a while due to this.

Copy link
Member

@bkamins bkamins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though @ronisbr could also have a look at it :). Thank you!

@ronisbr
Copy link
Member

ronisbr commented Oct 30, 2025

Hi! Sorry for the delay.

My suggestion is to change the new call to use the argument show_first_column_label_only = true instead of providing a new vector with column labels. This argument is the same as the previous show_subheader = false.

@pdeffebach pdeffebach merged commit ee9d199 into master Nov 1, 2025
13 checks passed
@pdeffebach pdeffebach deleted the prett_tables_version branch November 1, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants