Skip to content

Conversation

@dylan-asmar
Copy link
Member

A lot of tests depended on specific states and problems (e.g. rock positions). I removed use of a specific rng that "forced" some of these specific states and problems and instead dictated the specific problems or states where needed.

For the CI, removed the tests for macOS and windows. There should not be an OS specific issue with this package. If needed/desired, we can add back in. I also added tests for LTS of Julia in addition to the latest.

@dylan-asmar dylan-asmar linked an issue Nov 17, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.89%. Comparing base (3deaf60) to head (8bb09e5).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   93.89%   93.89%           
=======================================
  Files           8        8           
  Lines         262      262           
=======================================
  Hits          246      246           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dylan-asmar dylan-asmar merged commit c8b3566 into master Nov 17, 2025
4 checks passed
@dylan-asmar dylan-asmar deleted the remove_rng_references_in_tests_issue40 branch November 17, 2025 16:24
@zsunberg
Copy link
Member

Thanks @dylan-asmar !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Action space test failing

3 participants