Fix numeric formatting patterns by unwrapping scalar values #3135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

JonnyOThan merged 1 commit into KSP-KOS:develop from sisve:fix-string-format

Apr 7, 2025

Merged

Fix numeric formatting patterns by unwrapping scalar values #3135

Fix numeric formatting patterns by unwrapping scalar values

Annotations

10 warnings

src/kOS/Binding/FlightStats.cs#L18

The field 'FlightStats.stageValue' is never used

src/kOS/Suffixed/ConsumedResourceValueRCS.cs#L13

The field 'ConsumedResourceValueRCS.engine' is never used

src/kOS/Function/PrintList.cs#L150

Possible unintended reference comparison; to get a value comparison, cast the left hand side to type 'Object'

src/kOS/Suffixed/HsvaColor.cs#L45

'HsvaColor.CreateFromDump(SafeSharedObjects, Dump)' hides inherited member 'RgbaColor.CreateFromDump(SafeSharedObjects, Dump)'. Use the new keyword if hiding was intended.

src/kOS/Communication/Message.cs#L55

'Message.CreateFromDump(SafeSharedObjects, Dump)' hides inherited member 'BaseMessage.CreateFromDump(SafeSharedObjects, Dump)'. Use the new keyword if hiding was intended.

src/kOS/Communication/MessageQueue.cs#L12

'MessageQueue.CreateFromDump(SafeSharedObjects, Dump)' hides inherited member 'GenericMessageQueue<Message, PlanetariumTimeProvider>.CreateFromDump(SafeSharedObjects, Dump)'. Use the new keyword if hiding was intended.

src/kOS.Safe/Compilation/ProgramBuilder.cs#L174

Field 'ProgramBuilder.BuiltInPath.command' is never assigned to, and will always have its default value null

src/kOS.Safe/Compilation/KS/Scanner.cs#L29

Field 'Scanner.FileAndLine' is never assigned to, and will always have its default value

src/kOS.Safe/Execution/CPU.cs#L1467

The given expression is never of the provided ('NoDelegate') type

src/kOS.Safe/Encapsulation/UniqueSetValue.cs#L48

'UniqueSetValue<T>.Clear()' hides inherited member 'CollectionValue<T, HashSet<T>>.Clear()'. Use the new keyword if hiding was intended.