Fix RemoteTech API call for connection to unloaded vessels #3143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@JonnyOThan anyone available to review this workflow? |
…ortestSignalDelay for each vessel
Contributor
|
trying to see how to get the action to re-run.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://discord.com/channels/210513998876114944/210521126634389505/1403468719732166718
If the
GetSignalDelayToSatelliteAPI function call does not return a valid value for delay, tryGetShortestSignalDelay.This preserves any existing calls to the
GetDelay()function in RemoteTechConnectivityManager that may still need 2 vessels as arguments. But will fix this bug which is caused by theIsConnectedboolean that is determined from the Delay being > 0.