-
Notifications
You must be signed in to change notification settings - Fork 326
chore(deps): bump crypto deps; fix RSA prime=1 panic; update CI #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Bump rsa to 0.9.10, aws-lc-rs to 1.15.2, p384 to 0.13.1, sha2 to 0.10.9, wasm-bindgen-test to 0.3.56, and ed25519-dalek to 2.2.0. - Fix: prevent panic in RSA crate when a prime equals 1 by adding proper validation and handling. - Update component version in `ci.yml` to reflect dependency changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates cryptographic dependencies to their latest versions and includes CI workflow improvements. The RSA prime=1 panic fix mentioned in the PR title is addressed by upgrading the rsa crate to version 0.9.10, which contains the fix internally.
Key changes include:
- Dependency updates: rsa (0.9.6→0.9.10), aws-lc-rs (1.10.0→1.15.2), p384 (0.13.0→0.13.1), sha2 (0.10.7→0.10.9), ed25519-dalek (2.1.1→2.2.0), and several dev dependencies
- Code quality improvement in
validation.rsusing the#[default]attribute instead of manual Default implementation - GitHub Actions workflow updates (checkout v3→v6, setup-node v4→v6)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Bumps crypto and dev dependencies; updates feature syntax to use dep: prefix; increments version to 10.3.0 |
| src/validation.rs | Refactors Default trait implementation to use derive macro with #[default] attribute |
| benches/jwt.rs | Updates black_box import to use std::hint instead of criterion for compatibility with criterion 0.7 |
| CHANGELOG.md | Documents version 10.3.0 release with dependency updates and RSA panic fix; removes trailing whitespace |
| .github/workflows/ci.yml | Updates GitHub Actions versions (checkout v6, setup-node v6) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chore(deps): bump crypto deps; fix RSA prime=1 panic; update CI
wasm-bindgen-test to 0.3.56, and ed25519-dalek to 2.2.0.
validation and handling.
ci.ymlto reflect dependency changes.cc @Keats #476