Arxiv connection #18
Arxiv connection #18
Conversation
Arun-V18
commented
Aug 13, 2025
Arun-V18
commented
- please let me know if there is anything to possibly enhance this
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Arun-V18, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new integration for Arxiv, allowing the application to connect to and process data from the Arxiv academic preprint archive. This enhances the application's ability to gather and organize information from scientific research papers, specifically by extracting details from search results and creating structured data spaces.
Highlights
- New Arxiv Integration: A new connection module (ArxivConnection) has been added to support interactions with the Arxiv academic preprint database.
- Connection Manager Update: The ArxivConnection has been registered within the central CONNECTIONS array, enabling the application to recognize and utilize Arxiv URLs.
- Arxiv Data Processing: The new module includes functionality to trigger based on arxiv.org URLs, query the Arxiv API, parse the XML response to extract paper titles, links, and summaries, and then use this data to create structured "spaces" within the application.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a new connection for Arxiv, which is a great addition. The code is well-structured, but I have found a few areas for improvement to enhance its robustness and performance. My main concerns are a logic error in the pagination when fetching search results, a long delay between API calls that could affect user experience, and the use of a potentially brittle UI selector for injecting the interface. Addressing these points will make the new connection more reliable and efficient.
|
|
||
| const extractedData = []; | ||
| let idx = 1; | ||
| for ( let start = 0 ; start < 200; start += 20){ |
There was a problem hiding this comment.
The pagination logic in this loop is incorrect. You are fetching 50 results per API call (max_results=50), but the loop's start offset is only incremented by 20. This will cause overlapping results to be fetched in subsequent API calls, which is inefficient and will not produce the expected set of unique results.
The loop increment should match the max_results value to fetch distinct pages of results. Additionally, it's a good practice to define magic numbers like 200 and 50 as named constants for better code readability and maintainability.
| for ( let start = 0 ; start < 200; start += 20){ | |
| for ( let start = 0 ; start < 200; start += 50){ |
| snippet: summary | ||
| }); | ||
| } | ||
| await new Promise(r => setTimeout(r, 5000)); |
There was a problem hiding this comment.
A 5-second delay between API requests is quite long and will negatively impact the user experience by slowing down the data gathering process. The Arxiv API usage guidelines recommend making no more than one request every three seconds. You can safely reduce this delay to 3000ms to improve performance while still adhering to the rate-limiting guidelines.
| await new Promise(r => setTimeout(r, 5000)); | |
| await new Promise(r => setTimeout(r, 3000)); |
| await registerAuthCookies(); | ||
|
|
||
| const iframeScalerParent = await getSpacePortal(space_id, onMessage, registerListeners); | ||
| document.querySelector(".search-title")?.prepend(iframeScalerParent); |
There was a problem hiding this comment.
Using a class selector (.search-title) to inject the UI is brittle. This implementation depends on the current structure of the Arxiv website. If Arxiv's developers change the class name or the page layout, this selector will fail, and the connection will break. It would be beneficial to either find a more stable element to anchor the UI or add a comment acknowledging this fragility for future maintenance.
|
@Arun-V18 I'm having issues building the extension and I'm not very familiar with it, so I'll defer the review to the other people requested. |
