Check compute shaders compat #948
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix D3D Debug layer complaining about: D3D11 ERROR: ID3D11DeviceContext::Dispatch: The Shader Resource View in slot 0 of the Compute Shader unit has a sample count of 4, but the shader expects the sample count to be 2. This is invalid if the shader actually uses the view (e.g. it is not skipped due to shader code branching). [ EXECUTION ERROR Kenix3#421: DEVICE_DRAW_RESOURCE_SAMPLE_COUNT_MISMATCH]
Throw a slightly more useful message if not supported
Spodi
force-pushed
the
check-ComputeShaders-compat
branch
from
3ef800c to
33c1203
Compare
Spodi
force-pushed
the
check-ComputeShaders-compat
branch
from
33c1203 to
8eb3130
Compare
Contributor
Author
|
Closes in favor of #967 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a draft because I'm unsure about the ThrowWithMessage addition. Also everything feels hacked together somehow...
Loose follow up to #497
fix DEVICE_DRAW_RESOURCE_SAMPLE_COUNT_MISMATCH
we are already using shader model 4.1 for that, so we can just use the unsized version of Texture2DMS (probably not even needed, but the debug layer shuts up now)
add ThrowWithMessage
similar to ThrowIfFaled, but not bound to an actual thing failing (should this be done different?)
check GPU for ComputeShader support and throw a slightly more useful message if not supported (maybe this solves our feature level mystery?).
EDIT: It does! The error is triggered on Intel HD graphics 3000.
SoH build: HarbourMasters/Shipwright#5888