Skip to content

Validate logical pointer restrictions #6240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Validate logical pointer restrictions #6240

wants to merge 19 commits into from

Conversation

@alan-baker
Copy link
Contributor

  • Updates checks based on logical addressing to check logical pointers
  • Update pointer allocation validation
  • Add function call return pointer check
  • Add a new pass for logical pointer validation
    • checks valid logical pointer operands
    • checks logical pointer returns
    • checks same buffer requirement for VariablePointersStorageBuffer
    • checks variables must not:
      • be an operand to array length instructions
      • point to block arrays
      • point to an object containing a matrix
      • point to a component of a matrix

See internal SPIR-V issue 878.
Tested against Vulkan CTS. There are currently 41 failures. They are discussed in the SPIR-V issue.

@alan-baker alan-baker requested a review from dneto0 July 31, 2025 19:05
@alan-baker alan-baker force-pushed the val-logical-pointers branch from 67c3a0e to 7547ab5 Compare August 1, 2025 13:14
dneto0
dneto0 requested changes Aug 6, 2025
View reviewed changes
Copy link
Collaborator

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Very nice.

I think there's one bug repeated several times: disallowing StorageBuffer with VariablePointers capability alone should still be treated as a variable pointer usage.

dneto0
dneto0 approved these changes Aug 7, 2025
View reviewed changes
Copy link
Collaborator

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alan-baker
Validate logical pointer restrictions
3b8dd83 
* Tracks all variable pointers
* Validates pointer operands
@alan-baker
missing file
562708a
@alan-baker
Validate logical pointer returns
1a7e729
@alan-baker
cts based fixes
556f6ee
@alan-baker
Fixup variable pointer allocation check and tests'
ed2a2b3
@alan-baker
More logical pointer validation
fb39e31 
* improve function call checks
* improve ptr comparison checks
* validate typed variable pointers
  * may not be operands to array length
  * may not point to array of blocks
  * may not point to object containing matrix
  * may not point to component of a matrix
@alan-baker
fixes
f7049a1
@alan-baker
Refactor and new checks
1d815c1 
* Instruction tracing in a separate function
* Checker functions for untyped, typed and same buffer
@alan-baker
More untyped pointer related checks
23e8ecc
@alan-baker
CTS based fixes
19b0005
@alan-baker
tests
4f7373b
@alan-baker
other builds
aab2704
@alan-baker
more tests
5dd2147
@alan-baker
function call return type validation
92e0974
@alan-baker
remove member name
fa1329f
@alan-baker
more tests
f92d9f6
@alan-baker
fix build errors
97c0d6e
@alan-baker
Fixes
1c89052 
* Missed extensions SPV_NV_ray_tracing_motion_blur and
  SPV_AMD_shader_enqueue
* add relaxation option to a check
@alan-baker alan-baker force-pushed the val-logical-pointers branch from 7547ab5 to 1c89052 Compare October 10, 2025 01:47
@alan-baker alan-baker marked this pull request as ready for review October 15, 2025 23:41
@alan-baker
Copy link
Contributor Author

CTS updates in https://gerrit.khronos.org/c/vk-gl-cts/+/18442.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dneto0 dneto0 dneto0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alan-baker @dneto0