spirv-opt: Fix id overflow in ConvertToSampledImage #6339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ConvertImageVariableToSampledImage, the result of FindPointerToType is not checked before being passed to MoveInstructionNextToType. This can cause a crash if FindPointerToType returns 0. This CL adds a check to ensure type_id is not 0 before calling MoveInstructionNextToType. If type_id is 0, the function will return false.
luciechoi
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ConvertImageVariableToSampledImage, the result of FindPointerToType is
not checked before being passed to MoveInstructionNextToType. This can
cause a crash if FindPointerToType returns 0.
This CL adds a check to ensure type_id is not 0 before calling
MoveInstructionNextToType. If type_id is 0, the function will return
false.