spirv-opt: Handle id overflow in MergeReturnPass #6340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL adds error handling to the MergeReturnPass to gracefully handle cases where the pass runs out of IDs. The following functions were modified to return a boolean indicating success or failure: - AddNewPhiNodes - AddReturnFlag - AddReturnValue - BranchToBlock - CreatePhiNodesForInst - ProcessStructuredBlock - RecordReturned - UpdatePhiNodes The callers of these functions were updated to check the return value and propagate the failure. This prevents the pass from crashing when it runs out of IDs.
luciechoi
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds error handling to the MergeReturnPass to gracefully handle cases where the pass runs out of IDs.
The following functions were modified to return a boolean indicating success or failure:
The callers of these functions were updated to check the return value and propagate the failure. This prevents the pass from crashing when it runs out of IDs.