Make code fragments with JSON payloads fully valid#229
Open
TeksuSiK wants to merge 2 commits intoKickEngineering:mainfrom
Open
Make code fragments with JSON payloads fully valid#229TeksuSiK wants to merge 2 commits intoKickEngineering:mainfrom
TeksuSiK wants to merge 2 commits intoKickEngineering:mainfrom
Conversation
Bukk94
reviewed
Aug 20, 2025
| "profile_picture": "https://example.com/sender_avatar.jpg", // null if is_anonymous=true | ||
| "channel_slug": "gifter_channel", // null if is_anonymous=true | ||
| "identity": null // null if is_anonymous=true | ||
| "user_id": 987654321, |
Contributor
There was a problem hiding this comment.
After this change it's valid JSON. On the other hand, information about null fields when is_anonymous=true is lost and can be confusing to new people.
Contributor
Author
There was a problem hiding this comment.
That’s exactly why I moved this information higher up - it hasn’t been forgotten, but it isn’t included as part of the payload.
Fields in `gifter` are null if the gifter is anonymous (`gifter.is_anonymous`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request ensures that all code snippets containing JSON payloads are correct and can be copied with a single click by a developer, for example, to test receiving data from a webhook. All comments and headers that were included in the JSON have been moved above.