Feat: Adds support for pre-release building #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
reviewed
Oct 30, 2025
Contributor
Author
|
@pmalek Thanks for the feedback, tweaked the planning document based on the items you raised. |
rspurgeon
changed the title
pmalek
previously approved these changes
Nov 3, 2025
Member
pmalek
left a comment
pmalek
left a comment
There was a problem hiding this comment.
Minor nits but otherwise this is good 👍
I'll leave this with you to apply the suggestions
.github/workflows/bump-version.yaml
Outdated
Comment on lines
54
to
55
| SEMVER_COUNT=$(echo "$LABELS" | jq -r '.[]' | grep -cE '^(patch|minor|major)$' || echo "0") | ||
| PRERELEASE_COUNT=$(echo "$LABELS" | jq -r '.[]' | grep -cE '^(rc|alpha|beta)$' || echo "0") |
Member
There was a problem hiding this comment.
Nit: you should be able to achieve this without the grep usage:
Suggested change
| SEMVER_COUNT=$(echo "$LABELS" | jq -r '.[]' | grep -cE '^(patch|minor|major)$' || echo "0") | |
| PRERELEASE_COUNT=$(echo "$LABELS" | jq -r '.[]' | grep -cE '^(rc|alpha|beta)$' || echo "0") | |
| SEMVER_COUNT=$(echo "$LABELS" | jq -r '[. []| select(test("^(patch|minor|major)$"))] | length') | |
| PRERELEASE_COUNT=$(echo "$LABELS" | jq -r '[. []| select(test("^(rc|alpha|beta)$"))] | length') |
Comment on lines
16
to
18
| - '^docs:' | ||
| - '^test:' | ||
| - '^chore:' |
Member
There was a problem hiding this comment.
Suggested change
| - '^docs:' | |
| - '^test:' | |
| - '^chore:' | |
| - '^docs:' | |
| - '^test:' | |
| - '^tests:' | |
| - '^chore:' | |
| - '^ci:' |
pmalek
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.