fix: max messenger error #558
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix StackOverflowError on Cyclic Type References in Decompilation
This PR resolves "MAX messenger ERROR" by introducing cycle detection in the type reference visitor logic:
Closes #552
Prevents infinite recursion and StackOverflowError when decompiling bytecode with cyclic type references.
Adds a visited set to the ClassOrInterfaceType visitor in MyVoidVisitor.java to track and skip already-visited types.
Documents the cycle detection logic and provides troubleshooting notes for recursion errors.
All tests pass and the fix is validated with problematic and complex bytecode files.
Is there any feedback or additional edge cases you’d like tested before merging?
Note
Cyclic type references are common in obfuscated or complex class hierarchies. This fix ensures Bytecode Viewer fails gracefully and provides better error handling for such cases. If you have further suggestions for error reporting or cycle visualization, please let me know!