fix: prevent NPE by adding null check for JFileChooser initialization #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a potential NullPointerException that occurs when trying to use “Save as” or “Decompile and save” in Bytecode Viewer.
Cause:
The JFileChooser initialization could fail due to theme delegate issues in DarkLaf, leading to a null reference during export.
Fix:
Added a defensive null-check in FileChooser.create() to ensure the program safely handles the case where JFileChooser fails to initialize, instead of crashing.
Impact:
Prevents application crashes during export on certain Windows setups.
Improves stability for users on Java 21 and DarkLaf theme configurations.
Linked Issue:
Fixes #559