Always set 'title' element

[darrell-k]

Something's happening in XMLBrowser which messes up the title format when the extra metadata is passed back, so only return it when we've got the $tags parameter.

Maybe we should look at XMLBrowser, in case we ever wanted to use $tags in Default Skin requests?

[michaelherger]

This should be handled by XMLBrowser. See my comment in the other PR.

[darrell-k]

Changes as discussed in #103

[michaelherger]

Let's really try to leave the title alone. This should be the title and nothing else, as it might be used to look up additional metadata etc. Let's see whether anyone would miss that additional piece of information. The same applies to the asterisk for the samples.

[darrell-k]

The "explicit" indicator was a user-requested enhancement (there's also the * added for not-yet streamable tracks). Same argument as above applies: if it goes into line1 it needs to be in title.

But in this case, we could set a different element with these indicators, with corresponding client changes to append to the displayed title.

The [E] and * indicators may also be added to the album name. I think the solution at the album level would be to include in a version element (again with the necessary client changes). This is related to LMS-Community/slimserver#1398 which I need to finalise (although changing this for the plugin would not be dependent on that PR).

[michaelherger]

I'd be in support of an extra element for such additions. As you might know I'm often struggling trying to match names and titles to whatever a web site might be using. And all these additions complicate things considerably.

[darrell-k]

Just added a commit to keep album name and track title clean by adding elements: version for albums and titleFlags for tracks.

[SamInPgh]

Just added a commit to keep album name and track title clean by adding elements: version for albums and titleFlags for tracks.

I'm just curious as to why the "[E]" and "*" modifiers are added to the version element with a trailing space, e.g. "[E] ", rather than a leading space, e.g. " [E]", as was previously done with the title string. Typo, or am I missing something?

[michaelherger]

LGTM

[michaelherger]

LGTM

[darrell-k]

Just added a commit to keep album name and track title clean by adding elements: version for albums and titleFlags for tracks.

I'm just curious as to why the "[E]" and "*" modifiers are added to the version element with a trailing space, e.g. "[E] ", rather than a leading space, e.g. " [E]", as was previously done with the title string. Typo, or am I missing something?

Because unlike name/title, the new element starts off empty.