Set caseid on all sections in surgery form #871
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ERROR: A pull request from |
labkey-bpatel
approved these changes
Dec 18, 2024
bbimber
reviewed
Dec 18, 2024
| Ext4.create('EHR.window.OpenSurgeryCasesWindow', { | ||
| sourceStore: clientStore | ||
| sourceStore: clientStore, | ||
| caseUpdateStores: panel.storeCollection.clientStores.items, |
Collaborator
There was a problem hiding this comment.
This is picky, but wouldnt it be a little more normal to make a pointer to the StoreCollection, rather than 'items', which is more like an internal field of that class? Either accomplishes your goal, obviously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
If a section in the surgery form contains a caseid column, set that column value when selecting/creating a case. Assumes forms have one case per id. Can override caseUpdateStores if a different set of stores to be updated.
Related Pull Requests
Changes