Move SND module into ehrModules repository #894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mporary fix in Routes.tsx but crumb navigation is broken until the change to ComponentClass is accounted for in Crumb.
… from the current ViewContext
…modules this evening Revert: Add user to method signature so implementations don't have to grab it from the current ViewContext
… unrelated comments/string literals.
…roject and project revision UIs.
…o lookup when lookup key is selected. Queries the lookup table to get the values. Also getPackage API now returns property descriptor lookup options by default. 2. Sorted lookup key drop down. 3. Extensible columns can now define a column title for display in extra fields in package and project UI.
…support for FF 45 for selenium tests.
…components handle x-small bootstrap.
…. Do not show on this page. Fix locator on SND test.
-This includes modules17.3 r.55160 in which we removed hard coded values from DomainTemplate and did related refactoring. -This also includes merge of consolidated scripts ehr_billing-17.30-18.10 and wnprc_billing-17.30-18.10 (wnprc billing staging instance should already have tables and columns defined/updated in this merged script, so any new table or column additions in new scripts (18.10 and above) will be picked up when they upgrade. LabKey devs working on wnprc billing will have to use a new database if they are not already uptodate).
Testing feature branch on snd
… have the same SuperPkgId (#233) * added logic for finding duplicate superPkgIds * updated some comments * updated comments for better understanding of code * added check for existing eventDataId in map
…pulation for iterative updates (#243) * added logic for separating rows containing eventNoteIds * added isUpdate logic to getBulkSuperPkgs * added isUpdate logic to getBulkSuperPkgs * Merge alt key * error handling * added logic for separating rows containing eventNoteIds * added isUpdate logic to getBulkSuperPkgs * changed order of method calls * rebased with commits for alternate key * removed space * removed getEventNote method * EventNotesDataIterator * Remove unused variable --------- Co-authored-by: Marty Pradere <[email protected]>
* SND/Packages schema * SubjectId, Date, SequenceNum * EventData.objectid column * objectid FK * Filter on eventdata. Add qcstate. * Categories schema * Categories schema * Avoid lookup joins for perf * Bump schema versions to 25.000 (#248) * Remove commented out code --------- Co-authored-by: Marty Pradere <[email protected]> Co-authored-by: Adam Rauch <[email protected]>
This was referenced Feb 24, 2025
1. Want to ensure the importRows code path is only triggered by the initial data load 2. Changed criteria to look at the number of events instead of the number of eventData or AttributeData rows
labkey-tchad
force-pushed
the
24.11_fb_consolidateSnd
branch
from
1b19ba6 to
66135c6
Compare
labkey-martyp
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We are consolidating various repositories. SND is among them.
Note: This needs to be merged on the command line to preserve history
Related Pull Requests
Changes