Misc code cleanup; add vet to users and groups in tests #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 19, 2025
labkey-martyp
approved these changes
Mar 20, 2025
| { | ||
| Group assignedGroup = SecurityManager.getGroup(r.getUserId()); | ||
| if (assignedGroup != null && !assignedGroup.isProjectGroup()) | ||
| if (assignedGroup != null) |
Contributor
There was a problem hiding this comment.
Not really sure what the original use case was here. I don't see anyone using vets that wouldn't be listed in EHR or having different permissions at project level.
Collaborator
There was a problem hiding this comment.
I assume I wrote that, but it's been too long to recall. I cannot think of any reason to differentiate between site groups and project-level groups. If no center is actually using a project-level group in this table then it's a moot point and probably doesnt need to exist.
Given how long ago this was, it's equally likely that some long-ago quirk the in SecurityManager API required this kind of check for some reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Add a new vet user and group as part of automated test setup. Clear many IntelliJ warnings.
Changes
ehr_lookups.veterinariantable