Skip to content

Conversation

@labkey-jeckels
Copy link
Contributor

Rationale

We're getting intermittent but recurring test failures with logging like:

ERROR LogAction                2025-06-14T02:18:21,481     http-nio-8111-exec-6 : Assert true failed: Formulary is an empty map.
User: [email protected]
ReferrerURL: http://localhost:8111/Johns%20Hopkins%20RAR/EHR/ehr-dataEntryForm.view?formType=medicationTreatment
Browser: Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0
Platform: Linux x86_64

It's happening because the browser is rapidly navigating away from the data entry page while the request to load the formulary is still loading. We can avoid processing the response when the request was interrupted/failed, as the store handles showing the user an error dialog in scenarios like 500 errors from the server.

Changes

  • Only process the load when it was successful

@labkey-jeckels labkey-jeckels requested a review from a team June 16, 2025 20:30
@labkey-jeckels labkey-jeckels merged commit 69e412d into release25.3-SNAPSHOT Jun 16, 2025
7 of 9 checks passed
@labkey-jeckels labkey-jeckels deleted the 25.3_fb_formulary branch June 16, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants