Skip to content

Conversation

@cnathe
Copy link
Contributor

@cnathe cnathe commented Nov 7, 2024

Rationale

https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=51553

Related Pull Requests

Changes

  • should be 0.0d by default for backwards compatibility
  • set emptyWellValue to Double.NaN for AssayPlateMetadataServiceImpl.parsePlateGrids
  • convert Double.NaN values back to null before adding to dataRows

…n via the PlateReader implementation

- should be 0.0d by default for backwards compatibility
- set emptyWellValue to Double.NaN for AssayPlateMetadataServiceImpl.parsePlateGrids
- convert Double.NaN values back to null before adding to dataRows
@cnathe cnathe changed the base branch from develop to release24.11-SNAPSHOT November 7, 2024 14:11
@LabKey LabKey deleted a comment from github-actions bot Nov 7, 2024
@labkey-chrisj
Copy link
Contributor

Manual testing notes:

  • graphical import data with empty/missing values correctly appear as blank after import (not zero, non-numeric)
  • I will be adding regression coverage for this in my current assay-plate-import story https://github.com/LabKey/limsModules/issues/869

@cnathe
Copy link
Contributor Author

cnathe commented Nov 8, 2024

Manual testing notes:

@labkey-chrisj FYI, I did add selenium test coverage for this in the related PR here: https://github.com/LabKey/limsModules/pull/894/files#diff-d136e873f4845fda73ecdaa28412834d096d1007e72d706116acd591e8960e05R1094
Take a look and see if you think further testing is needed.

@cnathe cnathe merged commit 14d5b82 into release24.11-SNAPSHOT Nov 8, 2024
@cnathe cnathe deleted the 24.11_fb_plateNulls51553 branch November 8, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants