remote static files #6034
Merged
remote static files #6034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
requested changes
Nov 8, 2024
| } | ||
| catch (URISyntaxException e) | ||
| { | ||
| staticFilesPrefix = null; |
Contributor
There was a problem hiding this comment.
Won't this doom us to NPEs every time the method is called in the future? Some sort of logging about the bogus value would be useful too.
Contributor
Author
There was a problem hiding this comment.
It's fine. I cleverly made sure that this method is only called exactly once.
labkey-jeckels
approved these changes
Nov 8, 2024
…1_fb_static_files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
re-enable remote serving of static files (eval) given CORS and CSP
Related Pull Requests
Changes