Issue 51557: Avoid folder deletion summary stats type casting #6070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test suites: |
labkey-jeckels
approved these changes
Nov 19, 2024
labkey-susanh
approved these changes
Nov 19, 2024
labkey-nicka
force-pushed
the
24.11_fb_issue_51557x2
branch
from
3e3032c to
2cba00e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This is a followup to #6065 where the fix to casting switched from
LongtoInteger. That worked great on SQL Server, however, caused the same problem on Postgres instances. This fix avoids callingTableSelector.getValueMap()all together as it provides inconsistent type instances depending on the database type.Related Pull Requests
Changes
getResultSet()instead ofgetValueMap().