Issue 51694: Fix assay/plate schema upgrade #6071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-klum
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This addresses Issue 51694 by altering the upgrade approach to not need to traverse plate modeling and instead query for only the necessary data to perform the upgrade. Additionally, I've added null checks in
PlateImpl.from(PlateBean)to ensure we avoid any unboxing errors.Related Pull Requests
Changes
AssayUpgradeCode.updatePlateSetNames()as called by assay-24.000-24.001.sql to avoid calling into and traversing plate modeling logic which is subject to change.Booleanproperties inPlateImpl.from(PlateBean).