Skip to content

Conversation

@labkey-jeckels
Copy link
Contributor

Rationale

Creating containers is taking > 5 seconds on servers that have many sibling workbooks/

Changes

  • Don't update the max size statistic on caches on every put. Puts can happen many, many times for big caches, and getting the size is expensive enough to add up. We only show the max size in the Admin Console, so it's OK to be a little less granular
  • Avoid blowing away the container child cache when the hierarchy hasn't changed

sql.append(CORE.getTableInfoContainers());
sql.append(" SET ExpirationDate = ? WHERE RowID = ?");

// Note: jTDS doesn't support LocalDate, so convert to java.sql.Date
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI: SQL Server JDBC supports LocalDate. That's for another day, of course.

@labkey-jeckels labkey-jeckels merged commit 1344107 into release24.11-SNAPSHOT Nov 22, 2024
@labkey-jeckels labkey-jeckels deleted the 24.11_fb_51702_workbookCreationPerf branch November 22, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants