Restore override of handleConversionException in CoerceDataIterator (Issue 52098) #6748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| // Ignore conversion exceptions during coercion and just pass back the original value. |
Contributor
There was a problem hiding this comment.
Consider referring to Issue 52098 in this comment.
Contributor
Author
There was a problem hiding this comment.
Sure, I can do this, but it's not actually related to the fix for Issue 52098, only mistakenly removed in the course of fixing 52098. If I hadn't made that mistake, I wouldn't have annotated this method, so I'm somewhat inclined not to.
Contributor
There was a problem hiding this comment.
Makes sense. Just a contextual hook is all. I'm fine either way.
labkey-jeckels
approved these changes
Jun 11, 2025
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
I like Nick's suggestion. Otherwise, looks good and I validated the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
When addressing Issue 52098, the override of
addConversionExceptioninCoerceDataIteratorwas removed since we were opting to fail earlier for lookup resolution and it seemed appropriate to fail earlier for other conversions as well. Turns out we want to not fail earlier except for lookup resolution where it would be more burdensome for trigger scripts to understand how to resolve in the face of number names.Related Pull Requests
Changes