Skip to content

Issue 53831: check the true assay name length since we append onto the name when creating the assay domains (ex. "<assay name> Batch Fields") #7150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cnathe merged 5 commits into from
Oct 28, 2025
Merged

Issue 53831: check the true assay name length since we append onto the name when creating the assay domains (ex. "<assay name> Batch Fields") #7150

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
86d353b
Issue 53831: check the true assay name length since we append onto th…
cnathe Oct 27, 2025
13bf0f0
Issue 53831: set max assay name length to 150
cnathe Oct 27, 2025
0db07e7
move name length check back to AssayDomainServiceImpl
cnathe Oct 27, 2025
f577421
Merge branch 'develop' into fb_assayNameLength53831
cnathe Oct 28, 2025
3ccf9b9
typo
cnathe Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions assay/src/org/labkey/assay/AssayDomainServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,12 @@ public GWTProtocol saveChanges(GWTProtocol assay, boolean replaceIfExisting) thr
if (nameError != null)
throw new ValidationException(nameError);

// Issue 53831: add a specific check for assay name length since we append onto the name when creating the assay domains (ex. "<assay name> Batch Fields")
// which makes that actual max less than the DB size of 200
int assayNameLengthMax = 150;
if (assay.getName().length() > assayNameLengthMax)
throw new ValidationException("Value is too long for assay design name, a maximum length of " + assayNameLengthMax + " is allowed. The supplied value, '" + StringUtils.abbreviateMiddle(assay.getName(), "...", 50) + "', was " + assay.getName().length() + " characters long.");

if (isNew)
{
// check for existing assay protocol with the given name before creating
Expand Down