Fix includeNulls logic for generation of string_agg() #7195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-nicka
commented
Nov 10, 2025
Contributor
|
We've had problems with that before (this has been worked on by different developers). Is there an easy way to write a junit test for this? I might be a pain if it requires creating real tables to test. |
labkey-matthewb
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
With #7152 I introduced use of
string_agg()into the generated group concatenation SQL on PostgreSQL. There are a couple of test failures that indicated I had not properly accounted for handling of null values. This fixes that by doing coalescing as empty string.Related Pull Requests
Changes
array_to_string(array_agg())path from thestring_agg()path.