GitHub Issue 717: Reserve fields from ExpDataTable in DataClassDomainKind #7311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XingY
reviewed
Jan 6, 2026
| names.add("RunId"); // Issue 50461 | ||
| names.add("Container"); | ||
| // GitHub Issue 717 | ||
| names.addAll(Arrays.stream(ExpDataTable.Column.values()).map(ExpDataTable.Column::name).toList()); |
Contributor
There was a problem hiding this comment.
Should columns from ExpDataClassTable (such as nameexpression, datacount) also be reserved? This is the case for sampleType domain.
Contributor
Author
There was a problem hiding this comment.
Done. It seems a bit unnecessary but better to have them both doing the same kinds of reservations.
XingY
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Issue 717 The data class domain kind does not reserve fields from the ExpDataTable, in contrast to the corresponding domain kind and table for samples. This PR fixes that.
Related Pull Requests
Changes
ExpDataTable.Columns as reserved fields for data classes.