Revert ProtoBuf to 3.25.5 until we pick up regenerated code #1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-martyp
approved these changes
Mar 26, 2025
Contributor
labkey-martyp
left a comment
labkey-martyp
left a comment
There was a problem hiding this comment.
If there are extra requirements for upgrading this package, can you add them next to it in the notes of this doc. Or let me know and I'll add them.
Contributor
Author
I added a note. This is the first time we've had an incompatibility like this. I happened to discover the problem locally yesterday and didn't realize it was because of the library upgrade until this morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We need to regenerate some auto-generated code before we can upgrade to the latest ProtoBuf version. I have a PR in 24.11 that's already got that.
Changes