Enable a strong enforce CSP by default #1065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-matthewb
approved these changes
May 15, 2025
| """; | ||
| // Add upgrade_insecure_requests substitution, frame-ancestors, and e12 version for enforce CSP | ||
| String enforceCsp = baseCsp + """ | ||
| ${UPGRADE.INSECURE.REQUESTS} |
Contributor
There was a problem hiding this comment.
does this not need a ; at the end?
Contributor
Author
There was a problem hiding this comment.
The substitution adds the ;
This way, if running without HTTPS we don't get an extra semicolon
Contributor
Author
There was a problem hiding this comment.
This was referenced May 16, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Set a strong enforce CSP by default. Remove CSP properties from
application.propertiesfiles.Related Pull Requests