Skip to content

Conversation

@labkey-jeckels
Copy link
Contributor

@labkey-jeckels labkey-jeckels commented Sep 4, 2025

Rationale

We don't need JSPs for additional web apps.

Changes

  • Manually register the default servlet and other config, but don't register the JSP servlet
  • Manual Testing @labkey-adam
    • Use application.properties to configure an additional webapp
    • Create a simple JSP file in the additional webapp directory (a file with just <%= 5 + 3 %> works)
    • Ensure file is served up as simple text instead of rendering

@labkey-jeckels labkey-jeckels self-assigned this Sep 4, 2025
@labkey-jeckels
Copy link
Contributor Author

I recommend reviewing org.apache.catalina.startup.Tomcat.initWebappDefaults() to ensure that I copied the right initialization code - not too much, not too little.

Copy link
Contributor

@labkey-adam labkey-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against Tomcat sources and manually tested

@labkey-jeckels labkey-jeckels merged commit 1e0e9b7 into develop Sep 4, 2025
9 checks passed
@labkey-jeckels labkey-jeckels deleted the fb_53723_jspAdditionalWebapp branch September 4, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants