Slim down embedded dependencies #937
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Some dependencies in the embedded jar were included multiple times and others appear to be unnecessary. This removes 32 (~12MB) redundant, conflicting, or unneeded jars.
It's possible that one or more of these 32 jars is actually needed; @ankurjuneja may have more history here. I also plan to run BVTs and Dailies, and will merge after 24.12 branching to provide more bake time.
It's also possible we could eliminate a few more jars, but this PR seems like a good starting point.
Changes
tomcat-embed-corea dependency forbootstrapand stop pulling in redundant Tomcat dependencies therespring-boot-starter-json: seems unused and pulls in an old version of Jacksonjakarta.annotation-api: already present intomcat-annotations-apitomcat-juli: already present intomcat-embed-corespring-boot-starter-actuator: seems unusedspring-boot-starter-validation: eliminating a single@NotNullannotation lets us remove this and its dependenciesorg.jboss.logging.Logger(??) tolog4j