Accessibility: few semantic improvements #181
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Why: replace h4 to h3 with some extra Tailwind classes - Footer: add an accessible label for email input - Global styles: remove some unneeded CSS - Base layout: add <main> landmark element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #180
Fixed few minor accessibility issues reported in issue #180, no issues (issues from testing tools point of view only, didn't cover real world scenarios) after current fixes:
1. Why component: replace h4 to h3
Added some Tailwind classes to handle the styles based on this note from the main repo.
Since we're migrating to Tailwind classes to handle style, the updated styles are a bit slightly different than old styles, please let me know if this is ok.
Before
After
2. Posts component: replace h4 to h3
.text-lgchanged text font size to22.5pxfrom previous20px.Before
After
3. Global styles: remove some unneeded CSS after above changes
4. Base layout: add landmark element
5. Footer: add an accessible label for email input