Fix X11 controller crash/not working #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LemonCaramel
approved these changes
Apr 10, 2025
Owner
LemonCaramel
left a comment
LemonCaramel
left a comment
There was a problem hiding this comment.
Thank you for your contribution! I was late in reviewing this because I don’t have a device that runs X11 (and I still don’t).
To be honest, I don’t fully understand why changing the callbacks to standalone fields resolves the issue. I suspect it might be a memory allocation problem in JNA caused by garbage collection.
In any case, since I’ve received reports that this PR does resolve the problem, I’ve decided to merge it. Once again, I’m truly sorry for the delay.
LemonCaramel
pushed a commit
that referenced
this pull request
Apr 10, 2025
* Make callbacks in X11Controller as standalone fields * Add troubleshooting guide for Fcitx5 * Let's just reboot the machine
LemonCaramel
pushed a commit
that referenced
this pull request
Apr 13, 2025
* Make callbacks in X11Controller as standalone fields * Add troubleshooting guide for Fcitx5 * Let's just reboot the machine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22, may fix #23
Checked how CocoaInput handles X11Controller earlier, and looks like we need to make these callbacks as standalone fields to make sure they work and not crash the game.
IBus seems to work, Fcitx5 requires to enable "On The Spot" however, so this pr also includes a troubleshooting guide for these users.