refactor #644: update util file for toast notifications #646
Conversation
lillian-nguyen
requested review from
HoldUpFjord,
alexappleget,
bethanyann,
jennifertieu,
kepsteen,
nickytonline and
shashilo
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
shashilo
requested review from
a team and
shashilo
and removed request for
a team,
HoldUpFjord,
alexappleget,
bethanyann,
jennifertieu,
kepsteen,
nickytonline and
shashilo
Please fill out the PR template or put N/A for sections where it's not applicable. |
| @@ -0,0 +1,20 @@ | |||
| // Copyright (c) Gridiron Survivor. | |||
There was a problem hiding this comment.
I'm not used to this file naming @shashilo. Also, I think I'd colocate the types like they were prior to this change or is this our coding standard?
There was a problem hiding this comment.
We move all of our types into its own file. The prefix I just indicate these are where the Interfaces are located.
…ts' into lillian/644-update-util-for-toasts
| @@ -0,0 +1,20 @@ | |||
| // Copyright (c) Gridiron Survivor. | |||
There was a problem hiding this comment.
We move all of our types into its own file. The prefix I just indicate these are where the Interfaces are located.
lib/interfaces/Iutils.ts
Outdated
| export interface processExchangeForToastProps { | ||
| exchange: GiftExchangeWithMemberCount; | ||
| toast: ToastFunction; | ||
| today?: Date; |
Co-authored-by: Shashi Lo <[email protected]>
Co-authored-by: Shashi Lo <[email protected]>
…ts' into lillian/644-update-util-for-toasts
…ts' into lillian/644-update-util-for-toasts
Description
Before:
Interfaces for the Toast component were housed in the
lib/utils.tsfile.After:
interfaces/Iutils.ts)todayas propCloses #644
Testing instructions
N/A
Additional information
N/A
Pre-submission checklist
test #001: created unit test for __ component)Peer Code ReviewersandSenior+ Code Reviewersgroupsgis-code-questions