Skip to content

Conversation

@SkafteNicki
Copy link
Collaborator

@SkafteNicki SkafteNicki commented Dec 17, 2025

What does this PR do?

Fixes #21339
Fixes #5558

This is both a new and old issue. When gradient scaling is applied, optimizer.step() may be skipped if nan or inf is detected, and the learning rate scheduler detects that the optimizer didn’t step, which results in the warning that users are seeing. There is really nothing we can do to solve this, it requires some effort on the Pytorch side:
pytorch/pytorch#67590
but it has no activity for 4 years. This PR is an attempt at at least provide a bit more verbose output to the end user.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21426.org.readthedocs.build/en/21426/

@SkafteNicki SkafteNicki added the feature Is an improvement or enhancement label Dec 17, 2025
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 17, 2025
for w in caught:
msg = str(w.message)

if "lr_scheduler.step()" in msg and "optimizer.step()" in msg:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if "lr_scheduler.step()" in msg and "optimizer.step()" in msg:
if "Detected call of `lr_scheduler.step()` before `optimizer.step()`." in msg:

There's another warning (here) that fit in the original if statement. The proposed one should be more specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lr_scheduler.step() must be called before optimizer.step() Mixed precision: scheduler and optimizer are called in the wrong order

2 participants