Raise more verbose warning for gradient scaling in scheduler/optimizer case #21426
+60
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #21339
Fixes #5558
This is both a new and old issue. When gradient scaling is applied,
optimizer.step()may be skipped ifnanorinfis detected, and the learning rate scheduler detects that the optimizer didn’t step, which results in the warning that users are seeing. There is really nothing we can do to solve this, it requires some effort on the Pytorch side:pytorch/pytorch#67590
but it has no activity for 4 years. This PR is an attempt at at least provide a bit more verbose output to the end user.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21426.org.readthedocs.build/en/21426/