Skip to content

Add Example Grate: In Memory File System #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
stupendoussuperpowers wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add Example Grate: In Memory File System #4

stupendoussuperpowers wants to merge 9 commits into from
+2,144 −0

Conversation

@stupendoussuperpowers
Copy link
Contributor

@stupendoussuperpowers stupendoussuperpowers commented Sep 20, 2025

Closes: #2

rennergade
rennergade reviewed Sep 24, 2025
View reviewed changes
examples/imfs-grate/compile_grate.sh Outdated
@@ -0,0 +1,4 @@
#!/bin/bash

/home/lind/lind-wasm/clang+llvm-16.0.4-x86_64-linux-gnu-ubuntu-22.04/bin/clang -pthread --target=wasm32-unknown-wasi --sysroot /home/lind/lind-wasm/src/glibc/sysroot -Wl,--import-memory,--export-memory,--max-memory=1570242560,--export=signal_callback,--export=__stack_pointer,--export=__stack_low,--export=open_grate,--export=close_grate,--export=lseek_grate,--export=read_grate,--export=write_grate,--export=fcntl_grate,--export-table imfs_grate.c imfs.c -g -DLIB -DDIAG -D_GNU_SOURCE -O0 -o imfs_grate.wasm && /home/lind/lind-wasm/tools/binaryen/bin/wasm-opt --epoch-injection --asyncify -O2 --debuginfo imfs_grate.wasm -o imfs_grate.wasm && /home/lind/lind-wasm/src/wasmtime/target/release/wasmtime compile imfs_grate.wasm -o imfs_grate.cwasm
Copy link
Contributor

@rennergade rennergade Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this custom per grate or extensible?

Copy link
Contributor Author

@stupendoussuperpowers stupendoussuperpowers Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now it is per grate since we need to specify which grate functions are exported. I believe Alice is working on a way around this, so that we don't need to do function dispatches based on exports.

@stupendoussuperpowers stupendoussuperpowers mentioned this pull request Sep 24, 2025
Closed
marcelamelara
marcelamelara requested changes Oct 10, 2025
View reviewed changes
Copy link

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've reviewed the README, and have a few places where I think clarification would help. I also think we should revisit some default settings, if possible.

@stupendoussuperpowers stupendoussuperpowers mentioned this pull request Dec 20, 2025
Open
14 tasks
@stupendoussuperpowers
IMFS Updates
70628ac 
- Fix comments on the README

- Working version compatible with lind-wasm changes

- New folder structure + compile script for grates

- Add tests, remove random logs

- clang-format
@stupendoussuperpowers
Copy link
Contributor Author

stupendoussuperpowers commented Dec 23, 2025

Re-requesting review from @rennergade and @Yaxuan-w. Need inputs on this:

  • I've changed the structure to be more uniform, with source code in the src/ folder and the tests in the tests/ folder.
  • Additionally, there's a build.conf file that is expected in the root of every grate, this is because we need to know the entry point for this grate. Optionally, you can also pass down --max-memory or C_FLAGS as needed, they were needed for IMFS and will likely be needed for other grates as well.
  • Right now, I've added a compile_grate.sh in the imfs folder, which works like ./compile_grate.sh <folder for the grate>. This will be moved outside of the example repo once I file an Issue to provide general purpose tools/templates to this repo.

My basic logic is that we should ideally have a uniform way for building and running these example grates.

@rennergade rennergade requested a review from J7-7-7 December 23, 2025 16:09
@J7-7-7
Copy link

J7-7-7 commented Dec 29, 2025 •
edited
Loading

compile_grate.sh hard-codes toolchain paths under /home/lind/..., could we make these env-overridable (or derived from LIND_WASM_ROOT) so it's easier?

build.conf sets C_FLAGS=... but the script only reads EXTRA_CFLAGS, so those flags never get applied unless users manually set EXTRA_CFLAGS

rennergade
rennergade approved these changes Dec 31, 2025
View reviewed changes
Copy link
Contributor

@rennergade rennergade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. @Yaxuan-w can you review when you have a chance? Feel free to merge if you approve

Yaxuan-w
Yaxuan-w requested changes Jan 7, 2026
View reviewed changes
Copy link
Member

@Yaxuan-w Yaxuan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Would be helpful to have comments about general description and functionality at top of each file

examples/imfs-grate/src/imfs_grate.c
Copy link
Member

@Yaxuan-w Yaxuan-w Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need more comments

examples/imfs-grate/compile_grate.sh
Copy link
Member

@Yaxuan-w Yaxuan-w Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments on usage

@Yaxuan-w
Copy link
Member

Yaxuan-w commented Jan 7, 2026

Also, would be helpful to open up an issue about adding more tests about imfs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yaxuan-w Yaxuan-w Yaxuan-w requested changes

@marcelamelara marcelamelara marcelamelara requested changes

@rennergade rennergade rennergade approved these changes

@J7-7-7 J7-7-7 Awaiting requested review from J7-7-7

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add IMFS Example Grate.

5 participants

@stupendoussuperpowers @J7-7-7 @Yaxuan-w @rennergade @marcelamelara