Skip to content

Add per password salt length configuration #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add per password salt length configuration #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
952fcd1
Enhance PasswordHashing to support control per password salt length
pctimhk Mar 2, 2024
5bd09b3
Enhance PasswordHashing to support control per password salt length
pctimhk Mar 2, 2024
476bd17
Add BUAT and PUAT environment configuration
pctimhk Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions csharp-password-hash/csharp-password-hash/Hashing.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,12 @@ public static bool CheckPassword(string password, string salt, string hash, Hash
};
}

public static string GenerateSalt()
public static string GenerateSalt(int length)
{
const string chars = "ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789abcdefghijklmnopqrstuvwxyz";
var random = new Random((int)DateTime.Now.Ticks & 0x0000FFFF);
return new string(
Enumerable.Repeat(chars, 8)
Enumerable.Repeat(chars, length == 0 ? 8 : length)
.Select(s => s[random.Next(s.Length)])
.ToArray());
}
Expand Down
1 change: 1 addition & 0 deletions csharp-password-hash/csharp-password-hash/HashingConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ public class HashingConfig
[ObsoleteAttribute("Use GeneratePerPasswordSalt instead", false)]
public bool GenratePerPasswordSalt { get { return GeneratePerPasswordSalt; } set { GeneratePerPasswordSalt = value; } }
public bool GeneratePerPasswordSalt { get; set; }
public int PerPasswordSaltLength { get; set; }
public string GlobalSalt { get; set; }

public string SaltedPasswordFormat { get; set; }
Expand Down
2 changes: 1 addition & 1 deletion csharp-password-hash/csharp-password-hash/PasswordHashing.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public bool CheckPassword(string password, HashingConfig passwordEncryption,
public string GetHash(string password, HashingConfig hashConfig)
{
var salt = hashConfig.GeneratePerPasswordSalt
? Hashing.GenerateSalt()
? Hashing.GenerateSalt(hashConfig.PerPasswordSaltLength)
: hashConfig.GlobalSalt;

var saltedPassword = GetSaltedPassword(password, salt, hashConfig.SaltedPasswordFormat);
Expand Down
1 change: 1 addition & 0 deletions csharp-password-hash/csharp-password-hash/csharp-password-hash.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<TargetFramework>netstandard2.0</TargetFramework>
<LangVersion>Latest</LangVersion>
<RootNamespace>CSharpPasswordHash</RootNamespace>
<Configurations>Debug;Release;BUAT;PUAT</Configurations>
</PropertyGroup>

<ItemGroup>
Expand Down