Deduplicate StrEnum #789
Open
Deduplicate StrEnum #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A single `StrEnum` class is defined and imported by `Order` and `Asset` classes. Resolves Lumiwealth#788
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| lumibot/tools/types.py | ✅ |
| lumibot/entities/asset.py | ✅ |
| lumibot/entities/order.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
|
@grzesir |
|
@grzesir |
|
@grzesir |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A single
StrEnumclass is defined and imported byOrderandAssetclasses.Resolves #788
Description by Korbit AI
What change is being made?
Deduplicate the
StrEnumimplementation by consolidating it intolumibot/tools/types.pyand updating references inasset.pyandorder.pyto import from this central location.Why are these changes being made?
These changes streamline the codebase by eliminating duplicate definitions of the
StrEnumclass, reducing redundancy, and ensuring consistent behavior across different modules. This approach also makes maintaining theStrEnumclass more manageable by centralizing its implementation.