Skip to content

Fix delete warning in tags albums#4049

Merged
ildyria merged 1 commit intomasterfrom
fix-delete-message
Jan 31, 2026
Merged

Fix delete warning in tags albums#4049
ildyria merged 1 commit intomasterfrom
fix-delete-message

Conversation

@ildyria
Copy link
Member

@ildyria ildyria commented Jan 30, 2026

Fixes #715

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced a simplified confirmation message for single album deletion, providing users with a clearer deletion prompt across all supported languages.
  • Bug Fixes

    • Disabled delete actions when operating within tag-based album views to prevent accidental deletions of album contents.

✏️ Tip: You can customize this high-level summary in your review settings.

@ildyria ildyria requested a review from a team as a code owner January 30, 2026 17:05
@coderabbitai
Copy link

coderabbitai bot commented Jan 30, 2026

📝 Walkthrough

Walkthrough

This change introduces a new localization key confirmation_tag across 24 language files for the delete album dialog. The Vue component AlbumDelete.vue now uses conditional logic to select between confirmation messages based on album state. Context menu deletion actions are gated by an additional check for undefined tagAlbum state.

Changes

Cohort / File(s) Summary
Localization Files
lang/ar/dialogs.php, lang/cz/dialogs.php, lang/de/dialogs.php, lang/el/dialogs.php, lang/en/dialogs.php, lang/es/dialogs.php, lang/fa/dialogs.php, lang/fr/dialogs.php, lang/hu/dialogs.php, lang/it/dialogs.php, lang/ja/dialogs.php, lang/nl/dialogs.php, lang/no/dialogs.php, lang/pl/dialogs.php, lang/pt/dialogs.php, lang/ru/dialogs.php, lang/sk/dialogs.php, lang/sv/dialogs.php, lang/vi/dialogs.php, lang/zh_CN/dialogs.php, lang/zh_TW/dialogs.php
Added confirmation_tag key to delete_album translation arrays, providing single-album deletion confirmation strings in respective languages.
Album Deletion Component
resources/js/components/forms/album/AlbumDelete.vue
Introduced confirm computed property that conditionally selects between dialogs.delete_album.confirmation and dialogs.delete_album.confirmation_tag based on modelAlbum state; added imports for computed and trans.
Context Menu Access Control
resources/js/composables/contextMenus/contextMenu.ts
Added check for undefined albumStore.tagAlbum to gate photo deletion actions, preventing deletions when tag-based album context is active.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Hopping through translations with joy so bright,
New confirmation tags put right, oh what delight!
Album deletions now conditioned with care,
Tag-based albums? Denied with flair!
Twenty-four tongues sing the same refrain,
A hop, skip, and bound—the changes sustain!

🚥 Pre-merge checks | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

🧪 Unit Test Generation v2 is now available!

We have significantly improved our unit test generation capabilities.

To enable: Add this to your .coderabbit.yaml configuration:

reviews:
  finishing_touches:
    unit_tests:
      enabled: true

Try it out by using the @coderabbitai generate unit tests command on your code files or under ✨ Finishing Touches on the walkthrough!

Have feedback? Share your thoughts on our Discord thread!


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ildyria ildyria merged commit 6545c83 into master Jan 31, 2026
213 of 239 checks passed
@ildyria ildyria deleted the fix-delete-message branch January 31, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Smart albums inconsistencies

1 participant