Updated Update-CMApplicationSource #355
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified from the original. Removed surplus lines. Moved filtering to the left. Reduced number of WMI queries, which seems to have a big impact on speed.
Update Update-CMApplicationSource.ps1
Contributor
Author
|
For review @JankeSkanke :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used VSCode's Format Document and added a few full stops to console output, so there are several cosmetic changes.
Simplified code for copying source files to destination, by always removing \ at the end of the string (does not cause error if \ is not present).
Changed to filtering left instead of using Where-Object when searching for applications. In environments with high number of applications, this speeds up the search.