feat: add function for stable sorting arrays #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordMidas
force-pushed
the
development
branch
2 times, most recently
from
6677ac8 to
ae825b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function seems important because we had a really mysterious bug in Reforged caused by a very sneaky bug in Dynamic Spawns Framework which wasn't really a bug but a consequence of the fact that the squirrel
array.sortdoes not preserve order for equal elements. It was causing units of equal cost in a unit block to become randomly ordered and this was not very obvious at all.We need a function that sorts in a stable way, at least for use cases where the order is important.